Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sign] Cleanup method opened #636

Merged
merged 3 commits into from
Dec 20, 2022
Merged

[Sign] Cleanup method opened #636

merged 3 commits into from
Dec 20, 2022

Conversation

flypaper0
Copy link
Contributor

@flypaper0 flypaper0 commented Dec 15, 2022 •
edited
Loading

Description

  • cleanup method opened
  • batch unsubscribe method implemented

Resolves #614, #627

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@arein arein added the accepted label Dec 15, 2022
@flypaper0 flypaper0 changed the base branch from main to develop December 16, 2022 10:37
@flypaper0 flypaper0 marked this pull request as ready for review December 16, 2022 11:00
llbartekll
llbartekll approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing as always xd

@flypaper0 flypaper0 merged commit b5408d6 into develop Dec 20, 2022
@flypaper0 flypaper0 deleted the feature/open-cleanup branch December 20, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

@alexander-lsvk alexander-lsvk Awaiting requested review from alexander-lsvk

Assignees
No one assigned
Labels
accepted
Projects
Swift SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flypaper0 @llbartekll @arein